Remove extra spinner when viewing build #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizrabuya
requested review from
PriyaSudip,
jradtilbrook and
mcncl
as code owners
jradtilbrook
suggested changes
Jun 11, 2024
Contributor
|
I think most of the "build" commands take in |
Co-authored-by: Jarryd Tilbrook <jarryd@buildkite.com>
Contributor
jradtilbrook
left a comment
jradtilbrook
left a comment
There was a problem hiding this comment.
That looks good. Just need to check what other commands are doing with -w and update them as well
Contributor
Author
The other build commands do not show an extra spinner and the commands needed to show the spinner while the API's are being invoked from the background. But I will remove the extra spaces returned from the cli's output from the other build commands. |
…li into sup-2314-improve-open-in-web
jradtilbrook
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the sleep timer before opening the web URL in the browser. The timer caused the extra spinner to show. And to maintain consistency with the
bk agent viewcommand, the cli will not return an output if the -w flag is specified.