feat: add skills command group for use with LLMs#810
Merged
Conversation
7d6d60f to
161ddcb
Compare
catkins
reviewed
Apr 30, 2026
11cd84e to
8b6c6bf
Compare
| } | ||
| } | ||
| if !found { | ||
| return fmt.Errorf("skill %q not found in github.com/%s", skillName, defaultRepo) |
There was a problem hiding this comment.
The error message hardcodes defaultRepo but should use the actual repository that was specified. When a user provides a custom repo via the --repo flag, and the skill is not found, the error message will incorrectly reference github.com/buildkite/skills instead of the actual repository used.
// extractSkill needs to accept the repo parameter
func extractSkill(archive, skillName, dest, repo string) error {
// ...
if !found {
return fmt.Errorf("skill %q not found in github.com/%s", skillName, repo)
}
return nil
}Then update the call sites (lines 313, etc.) to pass the repo parameter through the call chain.
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Contributor
Author
There was a problem hiding this comment.
We only want to use the buildkite/skills repo
matthewborden
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a command set for
skillto enable adding Buildkite relevant skills to an LLM configChanges
skillcommand set withadd,updateanddeleteoptionsUsage
Testing
go test ./...)go fmt ./...)