Upgrade google/go-github to v89 and refactor client initialization - #440
Merged
Conversation
Signed-off-by: Chiman Jain <chimanjain15@gmail.com>
edmorley
added
type:dependency-upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
github.com/google/go-githubdependency to versionv89(github.com/google/go-github/v89) and refactors GitHub API client initialization across all registry command entry points.Key Changes
github.com/google/go-github/v89tov89.0.0ingo.modand updated package imports across the codebase.github.NewClient(...)invocations across CLI tools to leveragegithub.WithAuthToken(t)for authentication, with proper error handling on client creation:registry/add-entry/cmd/main.goregistry/yank-entry/cmd/main.goregistry/request-add-entry/cmd/main.goregistry/request-yank-entry/cmd/main.goregistry/verify-namespace-owner/cmd/main.goregistry/internal/servicesto align withgo-github/v89types.v2.53.6.github.Stringtogithub.Ptr.