Skip to content

fix: honor retry-after and disabled key state#1

Merged
bulutmuf merged 1 commit into
bulutmuf:mainfrom
fengjikui:codex/honor-retry-after-quarantine
Jul 7, 2026
Merged

fix: honor retry-after and disabled key state#1
bulutmuf merged 1 commit into
bulutmuf:mainfrom
fengjikui:codex/honor-retry-after-quarantine

Conversation

@fengjikui

Copy link
Copy Markdown
Contributor

Summary

  • use provider retry-after values as the actual quarantine duration instead of only recording them
  • keep permanently disabled keys out of the no-active-key fallback path, while still allowing quarantined keys to recover
  • tighten a few Bun/fetch typings so the existing CI typecheck gate passes

Tests

  • bun test src/state.test.ts
  • bun test
  • bun run typecheck
  • git diff --check

@bulutmuf

bulutmuf commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Hi @fengjikui, thank you so much for your contribution! 🎉

You caught two very critical bugs here (the retry-after duration being ignored, and disabled keys breaking the fallback loop).

I just published a major v2.0.0 refactor which completely changed the architecture and caused some merge conflicts with your PR. I am currently resolving the conflicts manually on my end to integrate your logic into the new architecture, while making sure to preserve your commit authorship.

I will get this merged shortly. Thanks again for the great catch!

@bulutmuf bulutmuf merged commit 386ca71 into bulutmuf:main Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants