feat(controller): map konnectivity resources onto the StewardControlPlane addons - #114
Merged
Conversation
…lane addons The new ControlPlaneResourcesSpec.Konnectivity (butler-api v0.24.0) is a Steward addon rather than a top-level control plane component, so it is written into the StewardControlPlane addons block as addons.konnectivity.server.resources. capi-steward copies the addons block onto the TenantControlPlane, which renders the requests onto the konnectivity-server container. Emitted only when set; the merge in ResolveControlPlaneResources carries the per-tenant override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maps the new
ControlPlaneResourcesSpec.Konnectivity(butler-api v0.24.0) onto the hosted konnectivity-server. Konnectivity is a Steward addon, not a top-level control plane component, so it is written into the SCP addons block asaddons.konnectivity.server.resources(capi-steward copies the addons block to the TenantControlPlane, which renders it onto the container). Emitted only when set;ResolveControlPlaneResourcescarries the per-tenant override.Dependency
Requires butler-api v0.24.0 (adds the
konnectivityfield). go.mod bumped to the released tag.Test
builder_konnectivity_test.go: omitted keeps the konnectivity addon empty; explicit maps toaddons.konnectivity.server.resourceswith the requests.