Skip to content

fix(rem-l12): fixing typo in general manager comment#63

Merged
SocksNFlops merged 1 commit into
mainfrom
rem-l12-fix-typo-in-comment
Sep 18, 2025
Merged

fix(rem-l12): fixing typo in general manager comment#63
SocksNFlops merged 1 commit into
mainfrom
rem-l12-fix-typo-in-comment

Conversation

@SocksNFlops

@SocksNFlops SocksNFlops commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

Changes

  • Fixing typo in GeneralManager comment

Testing :

  • All unit tests pass

Reviewers:

@GuardianAudits

@SocksNFlops SocksNFlops self-assigned this Sep 18, 2025
@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown
File % Lines % Statements % Branches % Funcs
script/BaseScript.s.sol 71.43% (10/14) 85.71% (12/14) 50.00% (1/2) 33.33% (1/3)
script/CollateralSetup.s.sol 58.14% (25/43) 77.36% (41/53) 50.00% (3/6) 0.00% (0/7)
script/DeployAll.s.sol 97.06% (66/68) 98.53% (67/68) 66.67% (2/3) 80.00% (4/5)
script/DeployConsol.s.sol 65.52% (19/29) 84.38% (27/32) 100.00% (0/0) 0.00% (0/5)
script/DeployForfeitedAssetsPool.s.sol 50.00% (10/20) 76.19% (16/21) 100.00% (0/0) 0.00% (0/5)
script/DeployGeneralManager.s.sol 69.77% (30/43) 90.57% (48/53) 100.00% (0/0) 0.00% (0/8)
script/DeployInterestOracle.s.sol 25.00% (3/12) 44.44% (4/9) 100.00% (0/0) 0.00% (0/4)
script/DeployLoanManager.s.sol 40.00% (6/15) 61.54% (8/13) 100.00% (0/0) 0.00% (0/4)
script/DeployNFTMetadataGenerator.s.sol 23.08% (3/13) 33.33% (3/9) 100.00% (2/2) 0.00% (0/4)
script/DeployOrderPool.s.sol 57.14% (12/21) 76.19% (16/21) 100.00% (1/1) 0.00% (0/4)
script/DeployOriginationScheduler.s.sol 66.67% (22/33) 84.85% (28/33) 100.00% (0/0) 0.00% (0/6)
script/DeployPriceOracles.s.sol 51.85% (14/27) 75.00% (21/28) 50.00% (1/2) 0.00% (0/6)
script/DeployQueues.s.sol 64.71% (33/51) 85.96% (49/57) 100.00% (0/0) 0.00% (0/10)
script/DeploySubConsols.s.sol 62.16% (23/37) 85.42% (41/48) 100.00% (2/2) 0.00% (0/7)
script/DeployUSDX.s.sol 57.14% (12/21) 78.26% (18/23) 100.00% (0/0) 0.00% (0/4)
script/LocalhostSetupPart1.s.sol 100.00% (24/24) 100.00% (27/27) 100.00% (0/0) 100.00% (2/2)
script/LocalhostSetupPart2.s.sol 100.00% (42/42) 100.00% (49/49) 100.00% (0/0) 100.00% (3/3)
script/LocalhostSetupPart3.s.sol 100.00% (18/18) 100.00% (21/21) 100.00% (0/0) 100.00% (2/2)
src/Consol.sol 87.88% (29/33) 88.24% (30/34) 0.00% (0/4) 100.00% (6/6)
src/ConversionQueue.sol 88.61% (70/79) 93.00% (93/100) 57.14% (8/14) 88.89% (8/9)
src/ForfeitedAssetsPool.sol 90.70% (39/43) 95.35% (41/43) 85.71% (6/7) 90.00% (9/10)
src/ForfeitedAssetsQueue.sol 94.74% (18/19) 95.65% (22/23) 66.67% (2/3) 100.00% (1/1)
src/GeneralManager.sol 94.27% (263/279) 94.76% (253/267) 69.70% (23/33) 95.45% (63/66)
src/LenderQueue.sol 100.00% (41/41) 100.00% (46/46) 100.00% (6/6) 100.00% (8/8)
src/LoanManager.sol 98.36% (120/122) 98.18% (108/110) 86.67% (13/15) 100.00% (27/27)
src/MortgageNFT.sol 100.00% (24/24) 100.00% (19/19) 100.00% (2/2) 100.00% (7/7)
src/MortgageQueue.sol 98.46% (64/65) 97.06% (66/68) 100.00% (21/21) 100.00% (8/8)
src/MultiTokenVault.sol 92.54% (62/67) 92.96% (66/71) 54.55% (6/11) 100.00% (15/15)
src/OrderPool.sol 96.72% (59/61) 96.72% (59/61) 81.82% (9/11) 100.00% (11/11)
src/OriginationPool.sol 100.00% (58/58) 98.33% (59/60) 100.00% (12/12) 100.00% (10/10)
src/OriginationPoolScheduler.sol 94.66% (124/131) 95.04% (134/141) 81.82% (9/11) 90.32% (28/31)
src/PythInterestRateOracle.sol 77.27% (17/22) 78.26% (18/23) 50.00% (4/8) 100.00% (2/2)
src/PythPriceOracle.sol 80.95% (17/21) 80.00% (16/20) 25.00% (1/4) 100.00% (3/3)
src/QueueProcesssor.sol 100.00% (4/4) 100.00% (2/2) 100.00% (0/0) 100.00% (2/2)
src/RebasingERC20.sol 95.65% (22/23) 100.00% (22/22) 100.00% (5/5) 83.33% (5/6)
src/StaticInterestRateOracle.sol 100.00% (7/7) 100.00% (8/8) 100.00% (1/1) 100.00% (2/2)
src/SubConsol.sol 100.00% (41/41) 100.00% (37/37) 100.00% (6/6) 100.00% (9/9)
src/USDX.sol 97.87% (46/47) 100.00% (65/65) 100.00% (5/5) 87.50% (7/8)
src/UsdxQueue.sol 94.74% (18/19) 95.65% (22/23) 66.67% (2/3) 100.00% (1/1)
src/libraries/MortgageMath.sol 96.79% (151/156) 97.71% (171/175) 89.66% (26/29) 96.30% (26/27)
src/libraries/SharesMath.sol 93.33% (14/15) 90.91% (20/22) 83.33% (5/6) 100.00% (3/3)
src/types/OPoolConfigId.sol 100.00% (2/2) 100.00% (2/2) 100.00% (0/0) 100.00% (1/1)
test/BaseTest.t.sol 95.03% (172/181) 96.13% (174/181) 60.00% (3/5) 86.67% (13/15)
test/integration/10_complexHistory.t.sol 99.60% (500/502) 100.00% (529/529) 100.00% (2/2) 33.33% (1/3)
test/integration/11_conversionRefinance.t.sol 98.37% (181/184) 99.47% (186/187) 100.00% (1/1) 33.33% (1/3)
test/integration/12_compoundingHalfConvert.t.sol 98.60% (141/143) 100.00% (149/149) 100.00% (0/0) 33.33% (1/3)
test/integration/13_convertedWithPenalties.t.sol 97.78% (132/135) 99.28% (138/139) 100.00% (1/1) 33.33% (1/3)
test/integration/14_compoundingNoPlanConversion.t.sol 98.71% (153/155) 100.00% (159/159) 100.00% (0/0) 33.33% (1/3)
test/integration/15_halfConverted.t.sol 98.47% (129/131) 100.00% (135/135) 100.00% (0/0) 33.33% (1/3)
test/integration/16_redeemAndDequeue.t.sol 98.13% (105/107) 100.00% (110/110) 100.00% (0/0) 33.33% (1/3)
test/integration/17_forecloseAndDequeue.t.sol 98.15% (106/108) 100.00% (111/111) 100.00% (0/0) 33.33% (1/3)
test/integration/18_expandLowerConvert.t.sol 99.05% (209/211) 100.00% (219/219) 100.00% (0/0) 50.00% (2/4)
test/integration/19_enqueueAfterCreation.t.sol 97.89% (93/95) 100.00% (96/96) 100.00% (0/0) 33.33% (1/3)
test/integration/1_foreclosure.t.sol 98.29% (115/117) 100.00% (118/118) 100.00% (0/0) 33.33% (1/3)
test/integration/20_completeConversion.t.sol 98.48% (130/132) 100.00% (136/136) 100.00% (0/0) 33.33% (1/3)
test/integration/21_noRedeemDequeue.t.sol 97.92% (94/96) 100.00% (99/99) 100.00% (0/0) 33.33% (1/3)
test/integration/22_ogPoolDonation.t.sol 95.00% (38/40) 100.00% (37/37) 100.00% (0/0) 33.33% (1/3)
test/integration/23_requestWithGasFees.t.sol 96.00% (48/50) 100.00% (49/49) 100.00% (0/0) 33.33% (1/3)
test/integration/24_conversionSmallAmount.t.sol 98.26% (113/115) 100.00% (124/124) 100.00% (0/0) 33.33% (1/3)
test/integration/25_usdxQueueCancel.t.sol 95.12% (39/41) 100.00% (42/42) 100.00% (0/0) 33.33% (1/3)
test/integration/26_forfeitedAssetsQueueCancel.t.sol 97.65% (83/85) 100.00% (89/89) 100.00% (0/0) 33.33% (1/3)
test/integration/2_payAndRefinance.t.sol 98.43% (125/127) 100.00% (135/135) 100.00% (0/0) 33.33% (1/3)
test/integration/3_payAndPenaltyImposed.t.sol 98.47% (129/131) 100.00% (136/136) 100.00% (0/0) 33.33% (1/3)
test/integration/4_orderExpires.t.sol 97.40% (75/77) 100.00% (76/76) 100.00% (0/0) 33.33% (1/3)
test/integration/5_usdxMaximumCap.t.sol 97.92% (94/96) 100.00% (98/98) 100.00% (0/0) 33.33% (1/3)
test/integration/6_slowForeclosure.t.sol 97.62% (82/84) 100.00% (85/85) 100.00% (0/0) 33.33% (1/3)
test/integration/7_usdxDonation.t.sol 90.00% (18/20) 100.00% (17/17) 100.00% (0/0) 33.33% (1/3)
test/integration/8_consolDonation.t.sol 93.75% (30/32) 100.00% (31/31) 100.00% (0/0) 33.33% (1/3)
test/integration/9_usdxWithdraw.t.sol 96.47% (82/85) 98.88% (88/89) 100.00% (1/1) 33.33% (1/3)
test/mocks/MockERC20.sol 75.00% (6/8) 75.00% (3/4) 100.00% (0/0) 75.00% (3/4)
test/mocks/MockGatedERC20.sol 0.00% (0/14) 0.00% (0/13) 0.00% (0/2) 0.00% (0/4)
test/mocks/MockLenderQueue.sol 88.24% (15/17) 90.48% (19/21) 33.33% (1/3) 100.00% (1/1)
test/mocks/MockMortgageQueue.sol 100.00% (6/6) 100.00% (4/4) 100.00% (0/0) 100.00% (3/3)
test/mocks/MockNFTMetadataGenerator.sol 100.00% (4/4) 100.00% (2/2) 100.00% (0/0) 100.00% (2/2)
test/mocks/MockOriginationPoolDeployCallback.sol 100.00% (7/7) 100.00% (5/5) 100.00% (0/0) 100.00% (3/3)
test/mocks/MockOriginationPoolSchedulerUpgraded.sol 100.00% (2/2) 100.00% (1/1) 100.00% (0/0) 100.00% (1/1)
test/mocks/MockRouter.sol 50.75% (34/67) 55.07% (38/69) 23.08% (3/13) 54.55% (6/11)
test/mocks/MockYieldStrategy.sol 80.00% (8/10) 71.43% (5/7) 0.00% (0/2) 100.00% (3/3)
Total 93.52% (4980/5325) 96.29% (5318/5523) 73.96% (196/265) 68.85% (336/488)

@SocksNFlops
SocksNFlops merged commit 8744ad9 into main Sep 18, 2025
7 checks passed
@SocksNFlops
SocksNFlops deleted the rem-l12-fix-typo-in-comment branch September 18, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuardianAudits GuardianAudits Awaiting requested review from GuardianAudits

Assignees

@SocksNFlops SocksNFlops

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@SocksNFlops