Fixing an issue where no RequestDeviceList() would throw a NPE#175
Merged
qdot merged 1 commit intobuttplugio:masterfrom Jul 11, 2017
Merged
Fixing an issue where no RequestDeviceList() would throw a NPE#175qdot merged 1 commit intobuttplugio:masterfrom
qdot merged 1 commit intobuttplugio:masterfrom
Conversation
If the server has no devices, the device list within the deserialized message will be set to null rather than an empty list. Checking for null avoids the NPE.
blackspherefollower
added
bug
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 50.11% 50.38% +0.27%
==========================================
Files 65 65
Lines 2580 2584 +4
Branches 207 208 +1
==========================================
+ Hits 1293 1302 +9
+ Misses 1209 1203 -6
- Partials 78 79 +1
Continue to review full report at Codecov.
|
qdot
approved these changes
Jul 11, 2017
Member
qdot
left a comment
qdot
left a comment
There was a problem hiding this comment.
Honestly, deviceList.Devices should never be null, it should be an empty list. However, to get things up and running I'll approve this for now, and will file a followup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the server has no devices, the device list within the deserialized message
will be set to null rather than an empty list. Checking for null avoids the NPE.