fix(deps): force js-yaml past the quadratic-CPU advisory - #56
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses the GHSA-5p4m-2wfm-xmqj advisory by forcing js-yaml to patched versions via pnpm overrides and regenerating the lockfile so the resolved js-yaml version is outside the affected ranges.
Changes:
- Adds pnpm overrides for
js-yamlmajor lines (3 and 4) in the workspace rootpackage.json. - Regenerates
pnpm-lock.yamlto reflect the overrides and resolvejs-yamlto4.3.1. - Records the overrides in the lockfile metadata for reproducible installs.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds overrides and updates the resolved js-yaml version to 4.3.1 in the lockfile/snapshots. |
| package.json | Adds pnpm.overrides to force patched js-yaml versions during resolution. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Comment on lines
+57
to
+61
| "pnpm": { | ||
| "overrides": { | ||
| "js-yaml@3": "^3.15.1", | ||
| "js-yaml@4": "^4.3.1" | ||
| } |
GHSA-5p4m-2wfm-xmqj (CVSS 7.5) — quadratic CPU consumption while resolving !!omap — covers >=3.0.0 <3.15.1 and >=4.0.0 <4.3.1. Both copies here are transitive and build-time only, so nothing shipped is affected, but the advisory is what a scanner blocks a merge on. Patched rather than filtered out of the scan: the fix is a patch bump inside each major, and a scanner configured to ignore dev dependencies would stay blind once this advisory is gone.
msalvatti
force-pushed
the
fix/js-yaml-quadratic-cpu-advisory
branch
from
August 7, 2026 23:03
4d06ca3 to
1d369d9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (2)
pnpm-lock.yaml:370
- The lockfile records
@bymax-one/rust-authas requiring a peer ofnext: ^16.2.11, but this workspace currently resolvesnextto16.2.10(see importers section). This leaves the peer dependency unsatisfied and can produce install warnings or failures under strict peer checks; the lockfile should be regenerated after aligning the resolved Next.js version to >=16.2.11 (or reverting the peer requirement if that change was accidental).
pnpm-lock.yaml:370 - This lockfile update includes changes to the local
file:../rust-auth/packages/rust-authpackage metadata (engines + peerDependencies). Because that package lives outside this repository, these fields can drift based on the developer’s sibling checkout state and make lockfile regeneration non-reproducible. If the PR’s intent is only the js-yaml patch, consider regenerating the lockfile against the intended rust-auth state (or otherwise documenting why these additional changes are expected).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHSA-5p4m-2wfm-xmqj(CVSS 7.5) — quadratic CPU consumption while resolving!!omap— covers>=3.0.0 <3.15.1and>=4.0.0 <4.3.1. This repository's lockfile carried a version inside both ranges.Exposure
Both copies are transitive and build-time only — they reach here through the test and tooling chain, and parse nothing but this repository's own configuration files. Nothing shipped is affected. The reason to merge is that a scanner blocks on it:
nest-storagealready had a required OSV check refuse a merge over exactly this.Patched, not filtered
The fix is a patch bump inside each major, so there is no upgrade risk to weigh. Excluding dev dependencies from the scan instead would silence this advisory and every future one in the same position.
Where the override lives
In
pnpm-workspace.yamlfor repos on pnpm 11, and inpackage.jsonfor repos still on pnpm 9. pnpm 11 stopped reading thepnpmfield ofpackage.json: an override written there warns once and is then ignored, which produces a lockfile that never changes and a pull request that looks like a fix while changing nothing. The lockfile was checked after regeneration in each repo for that reason.Verification
pnpm install --lockfile-onlyregenerated the lockfile; it now resolves js-yaml to 3.15.1 and 4.3.1, with no version left inside either affected range.