-
Notifications
You must be signed in to change notification settings - Fork 3
docs: update GitHub Actions data masking tutorials to latest API #1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -73,16 +73,16 @@ Go to a project page, then click **Manage > Masking Exemptions**, you can grant | |||||
|
|
||||||
| ### In GitHub Workflow | ||||||
|
|
||||||
| Find the step `Apply masking exception`, which will apply the masking exception to the database and the process is similar, the code it calls Bytebase API is as follows: | ||||||
| Find the step `Apply masking exemption`, which will apply the masking exemption to the database and the process is similar, the code it calls Bytebase API is as follows: | ||||||
|
|
||||||
| ```bash | ||||||
| response=$(curl -s -w "\n%{http_code}" --request PATCH "${BYTEBASE_API_URL}/projects/${PROJECT_NAME}/policies/masking_exception?allow_missing=true&update_mask=payload" \ | ||||||
| response=$(curl -s -w "\n%{http_code}" --request PATCH "${BYTEBASE_API_URL}/projects/${PROJECT_NAME}/policies/masking_exemption?allowMissing=true&updateMask=payload" \ | ||||||
| --header "Authorization: Bearer ${BYTEBASE_TOKEN}" \ | ||||||
| --header "Content-Type: application/json" \ | ||||||
| --data @"$CHANGED_FILE") | ||||||
| ``` | ||||||
|
|
||||||
| By changing file `masking/projects/**/masking-exception.json`, create a PR and then merge, the change will be applied. | ||||||
| By changing file `masking/projects/**/masking-exemption.json`, create a PR and then merge, the change will be applied. | ||||||
|
||||||
| By changing file `masking/projects/**/masking-exemption.json`, create a PR and then merge, the change will be applied. | |
| By changing the file `masking/projects/**/masking-exemption.json`, creating a PR, and merging it, the change will be applied. |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -46,10 +46,10 @@ Go to **Data Access > Data Classification**, you can upload the classification f | |||||
|
|
||||||
| ### In GitHub Workflow | ||||||
|
|
||||||
| Find the step `Apply classification`, which will apply the classification to the database via API. All the classifications should be defined in one file in the root directory as `masking/classification.json`. The code it calls Bytebase API is as follows: | ||||||
| Find the step `Apply classification`, which will apply the classification to the database via API. All the classifications should be defined in one file in the root directory as `masking/data-classification.json`. The code it calls Bytebase API is as follows: | ||||||
|
||||||
| Find the step `Apply classification`, which will apply the classification to the database via API. All the classifications should be defined in one file in the root directory as `masking/data-classification.json`. The code it calls Bytebase API is as follows: | |
| Find the step `Apply classification`, which will apply the classification to the database via API. All the classifications should be defined in one file in the root directory as `masking/data-classification.json`. The code to call the Bytebase API is as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar: “the code it calls Bytebase API…” is unidiomatic. Rephrase to “the code to call the Bytebase API is as follows:” (or similar) for readability.