Pin Node.js to 24 in NPM publish workflow - #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MODULE_NOT_FOUND: Cannot find module 'sigstore'originating from npm's provenance code when using Node 26, so the workflow needs to use a toolchain that doesn't trigger the optional dependency resolution issue.Description
node-versionto24in.github/workflows/publish_npm.ymlfor the publish job.npm install -g npm@lateststep so the workflow uses the Node-provided npm instead of forcing a global upgrade.sigstoredependency during provenance setup.Testing
python - <<'PY' ... PYwhich verified thatnode-version: 24is present and thatnpm install -g npm@latesthas been removed, and it succeeded.git diff --checkbefore committing and it returned no issues.Codex Task