WasmModuleProcessor failing with when processing a wasm with an import/export TAG#76
Merged
Merged
Conversation
…ded generation for tag import. Export TAG has no generation but is skipped, enabling generation to complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My wasm file happens to have a TAG export, which the ModuleInterfaceCodegen is blowing up on (javaparser null reference), since exportFieldType = null.
The goal of this fix is just to stop it blowing up.
For imports it seemed trivial enough to add TAG support, so I did.