add mapping and String() method for enum type in generated bindings#128
Merged
ydnar merged 1 commit intobytecodealliance:mainfrom Jul 7, 2024
Merged
Conversation
Member
Author
|
for variant lookup, it seems a bit odd: e.g. I am wondering if using |
ydnar
requested changes
Jul 6, 2024
75608fd to
fcedc99
Compare
058aef5 to
714b997
Compare
ydnar
requested changes
Jul 6, 2024
Collaborator
ydnar
left a comment
There was a problem hiding this comment.
Looking better! Just one small tweak.
I'd like to figure out how to add tests for this, but we can do that in a follow-up PR.
714b997 to
fb780ba
Compare
ydnar
approved these changes
Jul 6, 2024
fb780ba to
3cbef77
Compare
ydnar
reviewed
Jul 6, 2024
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
3cbef77 to
780eb20
Compare
ydnar
approved these changes
Jul 6, 2024
ydnar
added a commit
that referenced
this pull request
Jul 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds String() method for enum type as discussed in #127
If this approach looks ok, I will also try to add for variant and flag types.