[wasm-metadata] Split lib.rs into separate files#1917
Merged
alexcrichton merged 11 commits intoNov 28, 2024
Conversation
Member
Author
|
CI is failing because of #1918 |
Member
Author
pchickey
approved these changes
Nov 28, 2024
yoshuawuyts
force-pushed
the
refactor-metadata
branch
from
bc5bccd to
9f204c6
Compare
Member
Author
|
Looks like this should be good to merge now! |
yoshuawuyts
changed the title
wasm-metadata into separate fileslib.rs into separate files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm planning to file a number of patches to
wasm-metadata, but I realized those would probably be easier to review if I split the file into separate files first. This splits the original 1500+ line file into separate files library and test files. This PR intentionally does not include any logic changes, all code is otherwise left unmodified. Thanks!edit: I guess I did add a one-line doc comment at the top of lib.rs. So technically that's one change :)