[wasm-metadata] warn on missing docs and Debug impls#1920
Merged
alexcrichton merged 3 commits intoNov 29, 2024
Conversation
and impl missing impls
yoshuawuyts
force-pushed
the
document-metadata
branch
from
368472d to
d1ded8c
Compare
Member
Author
|
#1917 has landed, this should be ready for review now! |
alexcrichton
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting as a draft since this depends on #1917 landing first. This provides some additional tidying up, ensuring everything is documented and we can't accidentally forget any
Debugimpls. Thanks!