Properly manage ownership of GC refs in passive element segments#13179
Merged
fitzgen merged 4 commits intobytecodealliance:mainfrom Apr 23, 2026
Merged
Properly manage ownership of GC refs in passive element segments#13179fitzgen merged 4 commits intobytecodealliance:mainfrom
fitzgen merged 4 commits intobytecodealliance:mainfrom
Conversation
We need to `clone_gc_ref` when pushing into the segment and `drop_gc_ref` when clearing the segment, similar to what we do for e.g. setting `VMGlobalDefinition`s. Fixes bytecodealliance#13066
pchickey
approved these changes
Apr 23, 2026
pchickey
reviewed
Apr 23, 2026
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
(Approved but I expect it will take some more twiddling to resolve the lint stuff cropping up in CI)
pull Bot
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Apr 24, 2026
…ecodealliance#13179) (bytecodealliance#13183) * Properly manage ownership of GC refs in passive element segments We need to `clone_gc_ref` when pushing into the segment and `drop_gc_ref` when clearing the segment, similar to what we do for e.g. setting `VMGlobalDefinition`s. Fixes bytecodealliance#13066 * fix cfg warnings * fix cfg_attr * remove cfg_attr Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
pull Bot
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Apr 24, 2026
In looking over bytecodealliance#13179 I found it a bit brittle to access `anyref` fields unconditionally where the determination that the type of the segment was a GC reference was made much further away. I also found it somewhat confusing to have methods like `clone_gc_ref` and `drop_gc_ref` applied to all values which happened to be noops for non-gc-ref types. I've refactored things a bit internally here to plumb a `WasmRefType` around and have additionally added comments to why `anyref` accessors are used despite the value possibly having an `exnref` or `externref` type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to
clone_gc_refwhen pushing into the segment anddrop_gc_refwhen clearing the segment, similar to what we do for e.g. settingVMGlobalDefinitions.Fixes #13066