Properly manage ownership of GC refs in passive element segments#13183
Merged
cfallin merged 1 commit intobytecodealliance:mainfrom Apr 23, 2026
Merged
Properly manage ownership of GC refs in passive element segments#13183cfallin merged 1 commit intobytecodealliance:mainfrom
cfallin merged 1 commit intobytecodealliance:mainfrom
Conversation
…ecodealliance#13179) * Properly manage ownership of GC refs in passive element segments We need to `clone_gc_ref` when pushing into the segment and `drop_gc_ref` when clearing the segment, similar to what we do for e.g. setting `VMGlobalDefinition`s. Fixes bytecodealliance#13066 * fix cfg warnings * fix cfg_attr * remove cfg_attr
cfallin
approved these changes
Apr 23, 2026
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
Let's hope that the mercurial distributed system gods don't eat this one, too...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-land #13179 after a seeming github bug reverted it during the landing of #13180