Apx add ndd#13916
Draft
jlb6740 wants to merge 3 commits into
Draft
Conversation
Add the runtime EVEX map-4 prefix builder (ND/NF/EGPR bits per APX spec rev 8, Fig. 3.3), wire it into the meta code generator, and enable the NDD `addq` instruction. Verified with a byte-exact encoding test (62 F4 F4 18 01 C2). Instruction selection (ISLE lowering) and EGPR register allocation are not part of this change; the `.clif` filetest cannot select these instructions yet.
Add a `use_apx` ISLE predicate and lower 64-bit `iadd` to the NDD form of `addq` (EVEX map 4) when the `has_apx` target flag is enabled. Gate the instruction on the `apx` assembler feature and align the NDD destination with the EVEX `vvvv` operand so the result is written to a fresh register without clobbering either input. Add filetests exercising the new lowering and the `has_apx` flag parsing.
github-actions
Bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.