Cranelift: simplify DataValue::eq - #13953
Conversation
cfallin
left a comment
There was a problem hiding this comment.
Thanks! Happy to merge once the rustfmt issue is fixed.
|
One possible note here is that this is an intentional idiom you'll find throughout Wasmtime in a number of places. The intentional part is that if a new variant is added the compiler's exhaustive-match checks flag the |
|
Ah, yeah, sorry, I should've registered that here -- brain saw wildcard -> wildcard and I missed that. Thanks; @dev-er1 we'll close this as above. |
|
In any case, thanks for the review. |
This simplifies the
PartialEqimplementation forDataValueby replacing the repeated... => falsematch arms with a single wildcard arm.No functional changes intended.