Reserve LoongArch64 fiber stack space before saving registers - #14030
Merged
cfallin merged 1 commit intoJul 30, 2026
Merged
Conversation
cfallin
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13885.
Decrement the LoongArch64 fiber stack pointer before saving callee-saved registers, then address each save within the reserved 0xa0-byte frame. This avoids writing below the current stack pointer before the frame is
allocated and matches the existing restore layout.
Testing
cargo check -p wasmtime-internal-fiber --target loongarch64-unknown-linux-gnucargo clippy -p wasmtime-internal-fiber --target loongarch64-unknown-linux-gnu -- -D warningscargo fmt --manifest-path crates/fiber/Cargo.toml -- --check