x64: Remove an add128 lower rule that turns out just hurts - #14056
Merged
alexcrichton merged 1 commit intoAug 6, 2026
Conversation
A local `fib` benchmark shows that without this lowering rule wasm is 8% slower than native, whereas with this lowering rule it's 24% slower than native. The "FIXME" comment turns out can be resolved by just deleting the entire rule.
alexcrichton
force-pushed
the
remove-slow-lowering-rule
branch
from
July 31, 2026 19:31
0dcd5a7 to
0253b6b
Compare
alexcrichton
changed the title
Member
Author
|
Sorry, hit submit too soon with too many commits, updated PR/description now |
github-actions
Bot
added
cranelift
cfallin
approved these changes
Aug 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A local
fibbenchmark shows that without this lowering rule wasm is 8%slower than native, whereas with this lowering rule it's 24% slower than
native. The "FIXME" comment turns out can be resolved by just deleting
the entire rule.