Cranelift: Prevent DSE across divergent paths - #14063
Open
subotac wants to merge 1 commit into
Open
Conversation
alexcrichton
requested review from
fitzgen
and removed request for
alexcrichton
August 2, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14053.
Cranelift's post-dominator tree only considers paths that reach an explicit CFG exit. Dead-store elimination could therefore treat an overwriting store as inevitable even when another path entered a divergent region,
where a trap could expose the earlier memory state.
Reject cross-block dead-store candidates when the original store can reach a divergent block without first passing through the overwriter. Add a CLIF regression covering the divergent path.
Testing:
cranelift-codegenunit testscargo clippy -p cranelift-codegen --all-targets -- -D warnings