Fix compile on latest Rust nightly - #14193
Merged
Merged
Conversation
Nightly Rust has a new trait solver enabled which trips up on type inference for some of Wasmtime's `bindgen!`-generated code. The minimized failure doesn't look obviously the fault of the new solver, nor the fault of Wasmtime here, so I've opted to just apply the fix here for now. This additionally handles a new recursion limit warning on nightly as well. Closes bytecodealliance#14192
alexcrichton
requested review from
cfallin and
fitzgen
and removed request for
a team
August 24, 2026 14:54
cfallin
approved these changes
Aug 24, 2026
cfallin
enabled auto-merge
August 24, 2026 15:12
Contributor
|
Has a rustc issue been opened for this? |
Member
Author
|
I've not yet opened an issue, no. If you'd like to though the minimal example is: pub trait HasData {
type Data<'a>;
}
pub fn with_getter<D2: HasData>(_get: fn(&()) -> D2::Data<'_>) {}
pub fn caller<D: HasData>(getter: fn(&()) -> D::Data<'_>) {
with_getter(getter); // ERROR
}to me this seems like an intentional fix for something that should have been ambiguous in the first place |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly Rust has a new trait solver enabled which trips up on type inference for some of Wasmtime's
bindgen!-generated code. The minimized failure doesn't look obviously the fault of the new solver, nor the fault of Wasmtime here, so I've opted to just apply the fix here for now. This additionally handles a new recursion limit warning on nightly as well.