Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

[BitSail-461][Fix]Add default maven properties#463

Merged
hk-lrzy merged 46 commits into
bytedance:masterfrom
hk-lrzy:bitsail-maven-461
Mar 24, 2023
Merged

[BitSail-461][Fix]Add default maven properties#463
hk-lrzy merged 46 commits into
bytedance:masterfrom
hk-lrzy:bitsail-maven-461

Conversation

@hk-lrzy
Copy link
Copy Markdown
Collaborator

@hk-lrzy hk-lrzy commented Mar 24, 2023

Prepare a Pull Request

  • Title: [BitSail-XYZ][XxxType] Title of the pull request

  • Fixes: #XYZ

Please change the PR title and the related issue number refer to the following description.

The above XYZ must be replaced with the actual GitHub Issue number, indicating that the current PR is used to solve the problem described in this Issue.

If you don't find an Issue that matches your changes, please Create Issue first, then commit this PR.

For more info about the contributing guide, see: Contributing Guide

Motivation

Describe what this PR does and what problems you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

Please pick either of the following options.

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests, example:)

    • com.bytedance.bitsail.core.EngineTest#testRunEngine
  • This change added tests and can be verified as follows:

    (example:)

    • Added unit tests for parsing of configs
    • Optimized integration tests for recovery after task failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

haoke added 30 commits December 22, 2022 16:30
@hk-lrzy hk-lrzy linked an issue Mar 24, 2023 that may be closed by this pull request
2 tasks
@hk-lrzy hk-lrzy merged commit 0fc6251 into bytedance:master Mar 24, 2023
hk-lrzy added a commit that referenced this pull request May 24, 2023
[BitSail-461]Fix maven execution fail in windows platform.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Maven] Fails to clean maven

1 participant