Skip to content

[fix][cp] Avoid overflow in IntervalYearMonthType::valueToString#381

Merged
WangGuangxin merged 2 commits intobytedance:mainfrom
WangGuangxin:cp_9061
Apr 1, 2026
Merged

[fix][cp] Avoid overflow in IntervalYearMonthType::valueToString#381
WangGuangxin merged 2 commits intobytedance:mainfrom
WangGuangxin:cp_9061

Conversation

@WangGuangxin
Copy link
Copy Markdown
Collaborator

@WangGuangxin WangGuangxin commented Mar 11, 2026

What problem does this PR solve?

Issue Number: close #191

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Avoid overflow in IntervalYearMonthType::valueToString.
Corresponding PR: facebookincubator/velox#9061

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Please describe the changes in this PR

Release Note:

Release Note:
- Fixed overflow in IntervalYearMonthType::valueToString. 

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

Summary: Pull Request resolved: facebookincubator/velox#9061

Reviewed By: xiaoxmeng, kewang1024

Differential Revision: D54856794

Pulled By: mbasmanova

fbshipit-source-id: 6c2b4111a7665d6e0bdd47a5ab1d37266b7f2482
@WangGuangxin WangGuangxin changed the title Avoid overflow in IntervalYearMonthType::valueToString (#9061) [fix][cp] Avoid overflow in IntervalYearMonthType::valueToString (#9061) Mar 11, 2026
@WangGuangxin WangGuangxin changed the title [fix][cp] Avoid overflow in IntervalYearMonthType::valueToString (#9061) [fix][cp] Avoid overflow in IntervalYearMonthType::valueToString Mar 30, 2026
@WangGuangxin
Copy link
Copy Markdown
Collaborator Author

cc @guhaiyan0221

Copy link
Copy Markdown
Collaborator

@guhaiyan0221 guhaiyan0221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@WangGuangxin WangGuangxin added this pull request to the merge queue Apr 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Apr 1, 2026
@WangGuangxin WangGuangxin added this pull request to the merge queue Apr 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 1, 2026
@WangGuangxin WangGuangxin added this pull request to the merge queue Apr 1, 2026
Merged via the queue into bytedance:main with commit c1fd295 Apr 1, 2026
7 checks passed
fzhedu pushed a commit to fzhedu/bolt that referenced this pull request Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants