[refactor] Introduce ConnectorObjectFactory#397
Merged
ZacBlanco merged 1 commit intobytedance:mainfrom Apr 3, 2026
Merged
Conversation
yingsu00
force-pushed
the
connector_refactor_2
branch
7 times, most recently
from
53a4015 to
665fe8d
Compare
Contributor
Author
|
@ZacBlanco can you please review? |
ZacBlanco
reviewed
Mar 23, 2026
Collaborator
ZacBlanco
left a comment
ZacBlanco
left a comment
There was a problem hiding this comment.
A few small nits and a question or two on the API design. Otherwise I am excited for this!
yingsu00
force-pushed
the
connector_refactor_2
branch
6 times, most recently
from
54e0e06 to
0edffd1
Compare
ZacBlanco
reviewed
Apr 1, 2026
Collaborator
ZacBlanco
left a comment
ZacBlanco
left a comment
There was a problem hiding this comment.
Just a few more minor things
| hiveSplit->length != std::numeric_limits<uint64_t>::max()) { | ||
| preloadBytes = static_cast<int64_t>(hiveSplit->length); | ||
| } | ||
| int64_t preloadBytes = split->splitSizeBytes(); |
Collaborator
There was a problem hiding this comment.
I think with this change we need to implement the splitSizeBytes() method inside of HiveConnectorSplit?
yingsu00
force-pushed
the
connector_refactor_2
branch
6 times, most recently
from
78f090a to
0f51182
Compare
…ns API - Add ConnectorObjectFactory abstract interface with factory methods for creating connector objects (splits, column handles, table handles, etc.) - Add ConnectorOptions base class and DynamicConnectorOptions subclass for typed factory method options; add makeOptions() helper - Add HiveObjectFactory implementing ConnectorObjectFactory for Hive connector - Add splitSizeBytes() virtual method to ConnectorSplit base class - Add registerObjectFactory() to ConnectorFactory for factory registration - Use ConnectorObjectFactory in TableScan operator
yingsu00
force-pushed
the
connector_refactor_2
branch
from
0f51182 to
aa9feb0
Compare
Contributor
Author
Done. @ZacBlanco Thank you for your thorough review. I've addressed your comments. Would you please review again? |
ZacBlanco
approved these changes
Apr 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Partially resolves #250
Type of Change
Description
Introduce ConnectorObjectFactory
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note: None
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes