feat(web): adopt shared UI design system for the first document workflow - #32
Merged
Conversation
…ocument workflow) Migrate the work shell, editor chrome, and landing/sign-in surfaces to the shared design system supplied by #27/#30 (vendored @fullstack-ai-infra/ui 0.2.0). - Workspace shell: responsive sidebar with compact mode, keyboard/focus management, and accessibility labels. The async route layout keeps server data fetching; the shared-UI Sidebar renders behind a 'use client' boundary (work-sidebar.tsx) so antd's module-scope createContext is never evaluated in Next's react-server graph. - Editor: legacy-fallback and parsed-content helpers; text/AI menus rebuilt on shared primitives. - Landing/sign-in/user pages: shared tokens, theme bootstrap script, responsive hero actions. - Tests: component coverage for the new shell (responsive workspace, auto-growing title, dialog store, toast, theme bootstrap, editor fallback/parsed content) plus a Playwright end-to-end baseline for the sign-in flow (committed snapshots). - Compatibility shims for the design system's narrower Button contract: Button asChild usages become buttonVariants anchors, and the local Button wrapper passes through standard HTML button attributes (role, aria-*, style, suppressHydrationWarning).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the first document workflow to the shared C design system (tracking record: #14), consuming the vendored
@fullstack-ai-infra/uipackage supplied by the doc#27 fix (#30).What lands
globals.css(@import '@fullstack-ai-infra/ui/styles.css'), replacing the local dark-first token block.src/components/ui/*wrappers.responsive-workspace.tsx+use-compact-workspace) with accessibility labels and i18n keys.e2e/signin.spec.ts(+ committed snapshots) wired into CI;e2e/workspace.spec.tsbehindtest:e2e:full.Landing fixes applied on top of the rebased tree
Sidebarmoved behind a'use client'boundary (work-sidebar.tsx); the async work layout previously imported the design system directly, which made Next evaluate antd (module-scopecreateContext) under the react-server graph and broke page-data collection.Button asChildusages (landing page, admin doc dialog, sign-in button) replaced withbuttonVariantsanchors — the shared Button declares noasChildprop.role,aria-*,style,suppressHydrationWarning) that call sites and tests rely on.waitFor: the shared Button remounts its element on state change, so pre-click references go stale even though the toggle works (DOM state is correct).Verification (local, Node 24.11.1)
npm run format✓,npm run lint✓npm run test-ci✓ — vitest 55 files / 285 tests, CLI 51/51npm run build:collaboration✓,npm run check:cli✓npm run build✓ — 23/23 pagesRefs #14 (tracking record); supply prerequisite: #27 / #30.