Emit sceneplayingtoggle event to disable history when playing#67
Merged
vincentfretin merged 1 commit intodevfrom Apr 16, 2026
Merged
Emit sceneplayingtoggle event to disable history when playing#67vincentfretin merged 1 commit intodevfrom
vincentfretin merged 1 commit intodevfrom
Conversation
… to backport that when undo stack was backported)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If forgot to backport that when undo stack was backported from my private editor.
It's used in
aframe-editor/src/lib/history.js
Lines 15 to 17 in 8b411d4
The changes done when the scene is playing should really be reverted when we pause again in my opinion, but that's another big feature to implement.