Replace full-library media session queue with 2-item current+next queue#56
Merged
Conversation
…ue (#55) The media session queue previously contained every song in the library (500-2000+ items), sent via Binder IPC on every song change. This could trigger TransactionTooLargeException, and since the queue update shared a try-catch with updatePlaybackState(), notification, and UI updates, a single failure would freeze all session state for external controllers. Changes: - Replace full-library queue with 2-item queue (current + next song) with full metadata and cover art, per MediaSession standard - Pre-select next song via PlaylistManager.selectNextQueueSong() (sequential when shuffle off, random when shuffle on) - All skip and auto-advance paths use the pre-selected next song, so the queued item always matches what actually plays - Isolate queue update in its own try-catch so failures don't block playback state, notification, or UI updates - Remove repeat mode (shuffle off wraps last→first, shuffle on plays endlessly random) - Remove notifyChildrenChanged() from song changes (browse tree only changes on folder rescan) https://claude.ai/code/session_01VWnwPnvGVt3i4QRTbyM47p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The media session queue previously contained every song in the library (500-2000+ items), sent via Binder IPC on every song change. This could trigger TransactionTooLargeException, and since the queue update shared a try-catch with updatePlaybackState(), notification, and UI updates, a single failure would freeze all session state for external controllers.
Changes: