Simplify remote presets to DMD Remote 2 + Custom only#79
Merged
Conversation
Replaces the multi-preset wizard (with a scrollable preset list, NavZone.Wizard, and unlimited "Custom N" presets) with a simple two-option toggle in the settings panel. - RemotePresetManager: rewritten to store a single custom preset (remote_custom_preset) and a boolean flag (remote_use_custom); removes allPresets, createCustomCopy, updateCustomPreset, deleteCustomPreset, nextCustomName - dialog_settings.xml: replaces btn_remote_keys with a MaterialButtonToggleGroup (DMD Remote 2 | Custom) and a "Map Remote…" button enabled only when Custom is active - panel_key_wizard.xml: removes Sub-screen A (preset list) entirely; keeps only the key-capture screen - strings.xml: removes 5 obsolete wizard strings; adds remote_control_label and btn_map_remote - MainActivity: removes NavZone.Wizard and all associated navigation branches; removes rebuildWizardPresetRows, activateWizardRow, scrollWizardToRow, updateWizardActiveLabel; rewrites openWizard → startRemoteCapture (goes directly to capture); closeWizard now returns to settings panel at item 8; adds cycleRemotePreset, updateRemotePresetToggle, updateMapRemoteButton helpers; SETTINGS_COUNT raised from 8 to 9 https://claude.ai/code/session_017kJCrAouVWy2DY7Jj5CKRY
c0dev0id
pushed a commit
that referenced
this pull request
Mar 3, 2026
setupSettingsPanel() accesses presetManager.isCustomActive() to set the initial state of the remote preset toggle. However, presetManager was initialized after setupSettingsPanel() was called, causing an UninitializedPropertyAccessException on every startup. Move presetManager and activePreset initialization to before the setupSettingsPanel() call so all dependencies are ready when needed. Fixes crash introduced in e989f40 (PR #79). https://claude.ai/code/session_01HzhyTn3rUSEsteqpe6RCi9
c0dev0id
added a commit
that referenced
this pull request
Mar 3, 2026
…#82) setupSettingsPanel() accesses presetManager.isCustomActive() to set the initial state of the remote preset toggle. However, presetManager was initialized after setupSettingsPanel() was called, causing an UninitializedPropertyAccessException on every startup. Move presetManager and activePreset initialization to before the setupSettingsPanel() call so all dependencies are ready when needed. Fixes crash introduced in e989f40 (PR #79). Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the multi-preset wizard (with a scrollable preset list, NavZone.Wizard, and unlimited "Custom N" presets) with a simple two-option toggle in the settings panel.