Fix goreleaser#54
Merged
evrardjp-cagip merged 2 commits intoca-gip:masterfrom Dec 18, 2024
Merged
Conversation
Something went wrong in the commit updating the version for goreleaser (04785e1). The Makefile was not appropriately updated. This is a problem, as the goreleaser is not using the right version, and could lead to failures. On top of that, the Makefile did not have all the phony inputs appropriately adapted and goreleaser did not include the right name of the image... (all of which was supposedly added in that commit). This fixes it by cleaning up all the code linked to goreleaser.
The current Dockerfile is using a templated string at runtime, instead of build time. This is inconvenient and does not work. This fixes it by using a single binary name. The alternative would be to use CMD.
jfpucheu
approved these changes
Dec 18, 2024
|
please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.