Skip to content

Adds IDP term#21

Open
cabb99 wants to merge 38 commits into
cabb99:masterfrom
stevenluo22:master
Open

Adds IDP term#21
cabb99 wants to merge 38 commits into
cabb99:masterfrom
stevenluo22:master

Conversation

@cabb99
Copy link
Copy Markdown
Owner

@cabb99 cabb99 commented Jun 10, 2024

No description provided.

Copy link
Copy Markdown
Owner Author

@cabb99 cabb99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revise the units

Comment thread openawsem/functionTerms/biasTerms.py Outdated
group = atomGroup # atomGroup = [0, 1, 10, 12] means include residue 1, 2, 11, 13.
n = len(group)
normalization = n*n
rg_square = CustomBondForce(f"1.0/{normalization}*r^2")
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the units. OpenMM default units are in nanometers and the factors seem to be in Angstrom.

Comment thread openawsem/functionTerms/biasTerms.py Outdated
structure_interactions.append(structure_interaction)
# print("Done reading")
# print(structure_interactions)
print(structure_interactions)
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this print.

print(f"Including partial q value computation, start residue index: {startResidueIndex}, end residue index: {endResidueIndex}, residueIndexGroup: {residueIndexGroup}")
def partial_q_value(oa, reference_pdb_file, min_seq_sep=3, a=0.1, startResidueIndex=0, endResidueIndex=-1, residueIndexGroup=None, print_residues = False, forceGroup=4):
if print_residues:
print(f"Including partial q value computation, start residue index: {startResidueIndex}, end residue index: {endResidueIndex}, residueIndexGroup: {residueIndexGroup}")
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the print statements

qvalue.addPerBondParameter("r_ijN")
qvalue.addPerBondParameter("sigma_ij")
for structure_interaction in structure_interactions:
#print(structure_interaction)
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment

unit = 10
else:
unit = 1
rg = CustomCVForce(f"{unit}*rg_square^0.5")
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep using the value_in_unit method for consistency

cabb99 added a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants