ci(cockpit-e2e): matrix-per-cap + submitAndWaitForResponse helper (Task #14)#469
Merged
Conversation
Task #14 in the pre-batching cleanup arc. Replaces the sequential bash for-loop in the cockpit-e2e job with a GitHub matrix (one runner per cap, max-parallel=5, fail-fast=false, summary job preserving the "Cockpit — e2e" required-check name). Also ships submitAndWaitForResponse helper in libs/e2e-harness/src/ — addresses the leaky sendPromptAndWait pattern surfaced by PR #462 (loading-state observability fails for fast-streaming aimock paths). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5-task plan: add submitAndWaitForResponse to harness, export from barrel, verify harness tests, replace cockpit-e2e job with matrix + summary, commit/push/PR. CI is the verification gate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replaces the sequential bash for-loop in the cockpit-e2e job with a GitHub Actions matrix strategy (one runner per cap, max-parallel=5, fail-fast=false). Adds a cockpit-e2e-summary job that preserves the "Cockpit — e2e" required-check name for branch protection. Drops the stale 5s sleep workaround (was a pre-per-cap-migration artifact for port 8123 collisions; each cap now binds its own pythonPort and matrix runners are fully isolated anyway). Ships submitAndWaitForResponse in libs/e2e-harness/src/ — waits directly on chat-message[data-role="assistant"][data-streaming="false"] instead of the Stop-generating button. Addresses the leaky-helper finding from PR #462: loading-state observability fails for fast-streaming aimock paths regardless of cap UI shape. Unblocks the Task #4 c-messages aimock re-pilot (and the 7-cap chat batch follow-up) by giving them a clean matrix entry pattern + a helper that doesn't depend on UI streaming state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The wiring spec previously required a literal `working-directory:
cockpit/<cap>/python` step in ci.yml. After the matrix migration in
this PR, that path moves into the matrix entry (`python: cockpit/...`)
and the working-directory is templated as `${{ matrix.cap.python }}`.
Spec now accepts either form, so matrix-templated jobs and any
remaining literal-step jobs both pass the cross-check.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wins
Files
Test plan
Follow-ups (out of scope)
🤖 Generated with Claude Code