Skip to content

test(c-messages): add aimock e2e (Task #4 pilot slice 1)#473

Merged
blove merged 1 commit into
mainfrom
claude/c-messages-repilot
May 19, 2026
Merged

test(c-messages): add aimock e2e (Task #4 pilot slice 1)#473
blove merged 1 commit into
mainfrom
claude/c-messages-repilot

Conversation

@blove
Copy link
Copy Markdown
Contributor

@blove blove commented May 19, 2026

Summary

Files

  • New: `cockpit/chat/messages/angular/e2e/{c-messages.spec.ts,playwright.config.ts,global-setup-impl.ts,tsconfig.json,fixtures/c-messages.json}` — generator output, fixture + spec hand-edited.
  • Modified: `cockpit/chat/messages/angular/project.json` (e2e Nx target), `.github/workflows/ci.yml` (matrix entry).

Spec assertions

  1. `c-messages: user message and AI response both render` — `submitAndWaitForResponse` → user bubble contains "Hello", assistant bubble contains "chat-messages capability demo".
  2. `c-messages: chat-message-list renders both turns` — count of `chat-message-list chat-message` equals 2. Regression coverage for PR fix(cockpit-chat): render messages in c-messages + c-input primitive demos #466's primitive-demo fix.

Test plan

  • CI `Cockpit — e2e (cockpit-chat-messages-angular)` matrix expansion passes.
  • CI `Cockpit — e2e` summary passes (no regression on existing 4 caps).
  • CI `Cockpit — build / test` passes (wiring spec auto-discovers the new cap).

Follow-ups

🤖 Generated with Claude Code

First slice of Task #4 (aimock e2e for newly-eligible caps).
Generated via scripts/generate-aimock-scaffold.ts --cap c-messages,
with hand-authored fixture content and spec assertions.

- 5 new e2e/ files (playwright config + global-setup-impl + tsconfig
  + fixtures/c-messages.json + c-messages.spec.ts).
- project.json gains the e2e Nx target.
- ci.yml matrix gains a c-messages entry.

Two spec tests:
- user message + AI response both render via submitAndWaitForResponse.
- chat-message-list renders both turns (regression coverage for
  PR #466's primitive-demo fix).

The demo was broken at the component level in PR #462 (raw
ChatMessageListComponent without projected templates). PR #466 fixed
that by projecting the four chat-message templates. This re-pilot
verifies the aimock e2e against the fixed demo.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
threadplane Building Building Preview, Comment May 19, 2026 7:53pm

Request Review

@blove blove merged commit 5fbe1f7 into main May 19, 2026
22 of 23 checks passed
@blove blove deleted the claude/c-messages-repilot branch May 19, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant