ci: wire root scripts vitest suites into a real CI test target - #916
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
blove
enabled auto-merge (squash)
September 1, 2026 03:45
blove
added a commit
that referenced
this pull request
Sep 1, 2026
`cockpit/deep-agents/footprint.spec.ts` and `libs/cockpit-docs/src/lib/docs-bundle.spec.ts` were executed by nothing: no vitest project included the first, and `cockpit-docs` had no `test` target at all. Both are wired in here, following #916 (give the orphan a target) and #918 (glob out-of-project cockpit specs into `nx test cockpit`). Wiring surfaced three further gaps, all fixed: - `cockpit-docs` and `cockpit-registry` were both unreachable. `nx test` does not walk `^test`, and the `library` job runs a hardcoded LIBS list that excludes them, so cockpit-registry's three specs had never run either. The cockpit job now uses `nx run-many` over all three projects. - The footprint specs resolved paths from `process.cwd()`, which under `nx test cockpit` is `apps/cockpit`. Left as-is they would have asserted against `apps/cockpit/cockpit/...` and passed vacuously. They now resolve from `import.meta.url`. - `cockpit/<product>/*.spec.ts` sits outside every project root, so `nx affected` attributes it to the untagged `root` project and a PR touching only those specs skipped the job that runs them. ci-scope now maps them onto the cockpit scope by path. The website `.mdx` assertions in all three footprint specs asserted the five-segment docs shape #918 deleted — the one docs-links.ts records as having "produced a URL that 404s for every product". They are removed, not weakened: that coupling is a table checked against the website's real content tree by apps/cockpit/src/lib/docs-links.spec.ts. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
added a commit
that referenced
this pull request
Sep 1, 2026
`cockpit/deep-agents/footprint.spec.ts` and `libs/cockpit-docs/src/lib/docs-bundle.spec.ts` were executed by nothing: no vitest project included the first, and `cockpit-docs` had no `test` target at all. Both are wired in here, following #916 (give the orphan a target) and #918 (glob out-of-project cockpit specs into `nx test cockpit`). Wiring surfaced three further gaps, all fixed: - `cockpit-docs` and `cockpit-registry` were both unreachable. `nx test` does not walk `^test`, and the `library` job runs a hardcoded LIBS list that excludes them, so cockpit-registry's three specs had never run either. The cockpit job now uses `nx run-many` over all three projects. - The footprint specs resolved paths from `process.cwd()`, which under `nx test cockpit` is `apps/cockpit`. Left as-is they would have asserted against `apps/cockpit/cockpit/...` and passed vacuously. They now resolve from `import.meta.url`. - `cockpit/<product>/*.spec.ts` sits outside every project root, so `nx affected` attributes it to the untagged `root` project and a PR touching only those specs skipped the job that runs them. ci-scope now maps them onto the cockpit scope by path. The website `.mdx` assertions in all three footprint specs asserted the five-segment docs shape #918 deleted — the one docs-links.ts records as having "produced a URL that 404s for every product". They are removed, not weakened: that coupling is a table checked against the website's real content tree by apps/cockpit/src/lib/docs-links.spec.ts. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
added a commit
that referenced
this pull request
Sep 1, 2026
#936) `cockpit/deep-agents/footprint.spec.ts` and `libs/cockpit-docs/src/lib/docs-bundle.spec.ts` were executed by nothing: no vitest project included the first, and `cockpit-docs` had no `test` target at all. Both are wired in here, following #916 (give the orphan a target) and #918 (glob out-of-project cockpit specs into `nx test cockpit`). Wiring surfaced three further gaps, all fixed: - `cockpit-docs` and `cockpit-registry` were both unreachable. `nx test` does not walk `^test`, and the `library` job runs a hardcoded LIBS list that excludes them, so cockpit-registry's three specs had never run either. The cockpit job now uses `nx run-many` over all three projects. - The footprint specs resolved paths from `process.cwd()`, which under `nx test cockpit` is `apps/cockpit`. Left as-is they would have asserted against `apps/cockpit/cockpit/...` and passed vacuously. They now resolve from `import.meta.url`. - `cockpit/<product>/*.spec.ts` sits outside every project root, so `nx affected` attributes it to the untagged `root` project and a PR touching only those specs skipped the job that runs them. ci-scope now maps them onto the cockpit scope by path. The website `.mdx` assertions in all three footprint specs asserted the five-segment docs shape #918 deleted — the one docs-links.ts records as having "produced a URL that 404s for every product". They are removed, not weakened: that coupling is a table checked against the website's real content tree by apps/cockpit/src/lib/docs-links.spec.ts. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap
Eight vitest spec files under root
scripts/— including the deployment-generator drift checks and framework-adapter branching specs from #894/#898 — were wired into no Nx target and run by nothing in CI. Only thenode:testsuites (ci-scope,ci-workflow,cockpit-matrix,cockpit-ports,verify-angular-support) were executed, via directnode --teststeps in ci.yml.Inventory (root scripts/.spec.)
nx test scriptsnx test scriptsnx test scriptsnx test scriptsnx test scriptsnx test scriptsnx test scriptsWiring
scripts(scripts/project.json) with an@nx/vitest:testtarget — same executor/config-file convention as the libs.scripts/vite.config.mtsincludes*.spec.{ts,mjs}and excludes the five node:test suites by name; a future node:test spec added without updating the exclude fails loudly under vitest instead of silently not running.scope:scripts-teststag + newscripts_testskey inscripts/ci-scope.mjs, sonx show projects --affectedflips the scope whenever any file inscripts/changes (verified with a probe commit: touchinggenerate-ag-ui-deployment-config.ts→scripts_tests=true).scripts-tests(npx nx test scripts), gated onpush || scripts_tests == 'true', and wired intorequired-pr-checks(needs + RESULT/SCOPE env +require_scoped) so a red run blocks the required PR check.ci-workflow.spec.mjsasserting the job, its scope gate, and its required-pr-checks wiring exist.Mutation evidence
GENERATEDheader →nx test scriptsexits 1 with the drift byte-equality + header specs failing (3 failed / 50 passed); restored → exit 0.npx nx test scriptsstep from ci.yml →node --test scripts/ci-workflow.spec.mjsgoes red (runs the root scripts vitest suites when the scripts project is affected); restored → green.Excluded: mit-cutover.spec.mjs (stale — needs a policy decision)
Never run since #881 landed it, and it now fails against main on two counts: it asserts
libs/licensingno longer exists (it is tracked and consumed by Angular bundles), and it asserts zero tracked references to the excluded competitor (yesterday's Mastra runtime content anddeployments/ag-ui-mastra/package-lock.jsonlegitimately contain them). Excluded with a comment invite.config.mts; reconcile the spec with current policy in a follow-up rather than weakening it silently here.Verification
nx test scripts: 7 files / 53 tests greennx test telemetrygreen;nx show projectsintact after the graph splitnpm ci, no lockfile changes🤖 Generated with Claude Code