Reduce acme challenge log noise - #396
Merged
mholt merged 2 commits intoJul 17, 2026
Merged
Conversation
The "looking up info for HTTP challenge" logs can become very noisy (they produced ~2M logs in 24 hours for us). Requests can come from external ACME clients and pre-checks for challenges not initiated by the server. So treat this case (where no issuer has stored a matching token) as DEBUG to reduce noise. Note that actionable failures will remain visible: - Storage lookup failures: WARN - Empty or corrupt challenge data: WARN - Certificate issuance/renewal failures: visible via existing error logs
A big chunk of the noisy "looking up info for HTTP challenge" logs are "context canceled". So also log these as DEBUG, but only do so when both the lookup error and HTTP request context are canceled.
mholt
approved these changes
Jul 17, 2026
mholt
left a comment
mholt
left a comment
Member
There was a problem hiding this comment.
Alright, I think this is an acceptable change, and probably makes the most sense. Thank you! And thanks for your team's sponsorship.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "looking up info for HTTP challenge" logs can become very noisy (they produced ~2M logs in 24 hours for us)
This PR changes two "expected" cases to log at DEBUG instead of WARN:
(see the individual commit messages for more detail)
FWIW: these changes have been running in our fork for the last week without any unexpected behavior AFAICS