Update version_match regex to handle pre-release semantic #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmoelder
reviewed
Jan 15, 2026
Contributor
schmoelder
left a comment
schmoelder
left a comment
There was a problem hiding this comment.
Is this backwards compatible?
Contributor
Author
Yes, since the version number is displayed between "cadet-cli version " and "(branch", the regex is just more inclusive now, basically matching anything between these two strings now. I dont think there was anything else there ever, at least not since v4.4, probably never |
jbreue16
force-pushed
the
feature/preReleaseVersion
branch
from
70bcaf5 to
0066d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new CADET-Core pre-releases, we must allow pre-release semantics in the
version_matchregex. Otherwise, CADET-Python fails with"CADET version or branch name missing from output.".