Skip to content

Fix autodetection of CADET executables on Windows PyPI installs#73

Merged
hannahlanzrath merged 1 commit intomasterfrom
fix_autodetect_for_pypi_dist
Apr 17, 2026
Merged

Fix autodetection of CADET executables on Windows PyPI installs#73
hannahlanzrath merged 1 commit intomasterfrom
fix_autodetect_for_pypi_dist

Conversation

@hannahlanzrath
Copy link
Copy Markdown
Collaborator

@hannahlanzrath hannahlanzrath commented Apr 17, 2026

When cadet-core is installed via PyPI on Windows, cadet-cli.exeandcreateLWE.exeare placed inScripts/rather thanbin/. The autodetection logic correctly resolves the prefix root via shutil.which, but resolve_cadet_pathsonly searchedbin/, causing a FileNotFoundError` on Windows.

This fix tries bin/ first (preserving existing behaviour on Linux, macOS, and manual installs), then falls back to Scripts/ for the Windows PyPI layout.

@hannahlanzrath hannahlanzrath force-pushed the fix_autodetect_for_pypi_dist branch from 4fcb0a9 to 1f75a42 Compare April 17, 2026 11:09
@hannahlanzrath hannahlanzrath changed the title fix: find cadet root for cadet-core pypi Windows distribution Fix autodetection of CADET executables on Windows PyPI installs Apr 17, 2026
@jbreue16 jbreue16 added the bug label Apr 17, 2026
Copy link
Copy Markdown
Contributor

@jbreue16 jbreue16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on windows 🥳

@hannahlanzrath hannahlanzrath merged commit 378b19b into master Apr 17, 2026
5 checks passed
@hannahlanzrath hannahlanzrath deleted the fix_autodetect_for_pypi_dist branch April 17, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants