Skip to content

This PR ensure backwards compatibility for the changes introduced with commit 6978223#112

Merged
hannahlanzrath merged 8 commits intomainfrom
fix/folder_to_directory_namechange_bwcompatibility
Feb 5, 2026
Merged

This PR ensure backwards compatibility for the changes introduced with commit 6978223#112
hannahlanzrath merged 8 commits intomainfrom
fix/folder_to_directory_namechange_bwcompatibility

Conversation

@hannahlanzrath
Copy link
Contributor

@hannahlanzrath hannahlanzrath commented Feb 3, 2026

This PR ensure backwards compatibility for the changes introduced with commit 6978223 and bumps version to 1.1.2.

@hannahlanzrath hannahlanzrath force-pushed the fix/folder_to_directory_namechange_bwcompatibility branch from 067ddce to 4003b88 Compare February 3, 2026 15:57
@schmoelder schmoelder force-pushed the fix/folder_to_directory_namechange_bwcompatibility branch 3 times, most recently from c19603a to 08da650 Compare February 4, 2026 18:27
@schmoelder
Copy link
Contributor

There was still a bit of work, but I think it runs now.

Note, I also cleaned up a bit and added made some more private attributes public properties. I don't think there's any harm in this. Also, I added a save_metadata method.

I also noticed that the following properties are basically the same:

  • output_directory
  • output_path
  • output_data

We should consider unifying this.

@hannahlanzrath hannahlanzrath force-pushed the fix/folder_to_directory_namechange_bwcompatibility branch 2 times, most recently from 4f39875 to 6f50fa3 Compare February 5, 2026 14:33
@hannahlanzrath
Copy link
Contributor Author

I also noticed that the following properties are basically the same:

  • output_directory
  • output_path
  • output_data

We should consider unifying this.

I opened #115

hannahlanzrath and others added 8 commits February 5, 2026 16:32
…rojectRepo classes

Change attribute name in ProjectRepo
…putRepo

Add "directory" naming backwarts compatibility to OutputRepo
Also move version update before the metadata is checked

Co-authored-by: Johannes Schmölder <j.schmoelder@fz-juelich.de>
Co-authored-by: Hannah Lanzrath <h.lanzrath@fz-juelich.de>
@hannahlanzrath hannahlanzrath force-pushed the fix/folder_to_directory_namechange_bwcompatibility branch from 6f50fa3 to a022630 Compare February 5, 2026 15:36
@hannahlanzrath hannahlanzrath merged commit 2f68fef into main Feb 5, 2026
6 checks passed
@hannahlanzrath hannahlanzrath deleted the fix/folder_to_directory_namechange_bwcompatibility branch February 5, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants