fix(macos): bound analyze per-child scan + stop menu-bar popover bounce - #256
Merged
Conversation
Hand-test fixes on the conductor build: - DiskScanner.scan takes a `timeout`; the per-child walk passes 20s so one huge child (a package cache with millions of files) times out + shows partial instead of stalling the whole scan for the full 300s (the "191/192" freeze on ~/Library / Home). - HUDController: NSScrollView elasticity = .none so the menu-bar popover no longer rubber-bands into empty space when the content fits (overflow past the screen cap still scrolls). - scanStreaming (opt-in `analyze --progress`) gets a 30s kill-timeout so a pathological tree can't block the reader indefinitely; its progress shows "N files" (unknown total) not a misleading "N/N". Streaming stays OFF by default — the per-child walk's "scanning <child> · k/N" progress is more informative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found while hand-testing the conductor build (all validated on a real build):
DiskScanner.scannow takes atimeout, and the per-child walk passes 20s — so one huge child (a package cache with millions of files) times out + shows partial instead of stalling the whole scan for the full 300s.HUDController'sNSScrollViewgetsverticalScrollElasticity = .none— no more rubber-banding into empty space when the content fits (overflow past the screen-height cap still scrolls).analyze --progress, off by default): a 30s kill-timeout so a pathological tree can't block the reader indefinitely, and the progress readsN files(unknown total) instead of a misleadingN/N.The conductor path is unchanged — analyze/status/history/clean still run through bundled
burrow→ bundled engine (confirmed viaps:burrow analyze→analyze-go). Streaming stays off by default; the per-child walk's 'scanning · k/N' progress is more informative.