fix(macos): augment conductor PATH with Homebrew bins (Finder-launch trap)#279
Merged
Conversation
…er-launch trap) A Finder/LaunchServices launch hands the app a stripped PATH — /usr/bin:/bin:/usr/sbin:/sbin, with NO /opt/homebrew/bin or /usr/local/bin. Absolute-path tools are fine (the bundled engine/conductor/fclones, /usr/bin/nettop, /usr/bin/brctl), but two things silently broke: a user-installed FALLBACK sidecar (e.g. `brew install fclones`, the workaround for builds without the bundled copy) was invisible to the conductor's PATH resolution, and the engine's own shell-outs to brew tools had the same blind spot. BurrowConductor.environment now prepends the Homebrew bins (idempotent, order-preserving) so PATH resolution matches what the user sees in a terminal. Found while auditing the fclones-class of "GUI depends on something not guaranteed present" bugs. Pure + unit-tested (augmentedPATH: strip→prepend, terminal→no-op, empty/nil→fallback).
caezium
force-pushed
the
fix/conductor-path-augment
branch
from
July 13, 2026 08:57
3da9250 to
6a4e632
Compare
caezium
added a commit
that referenced
this pull request
Jul 13, 2026
Version bump (macOS project.yml, Windows appxmanifest + csproj) + RELEASES.md. Carries everything since v0.10.0 (a8074d2): the Leftovers/Similar Photos/Network panes (#273) plus fclones bundling (#278), HEIC surfacing (#283), the HUD popover + lazy-mount fixes (#274/#275/#277), and the Finder-launch PATH fix (#279).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found auditing the fclones-class of bugs. A Finder-launched app gets a stripped PATH (
/usr/bin:/bin:/usr/sbin:/sbin— no/opt/homebrew/bin). Absolute-path tools are fine, but a user-installed fallback sidecar (thebrew install fclonesworkaround!) and the engine's own brew-tool shell-outs silently vanished.BurrowConductor.environmentnow prepends the Homebrew bins (idempotent, order-preserving). Pure + unit-tested (augmentedPATH).