Skip to content

Conversation

@prateekshadas
Copy link

@prateekshadas prateekshadas commented Mar 10, 2021

Clang fixes
Updated the macro caff_ms_to_ns to use ULL instead of UL
Moved setting of frames_droped bool value to CaffeineFramesTracker class


This change is Reviewable

Copy link

@turbodavidson turbodavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @prateekshadas)

@turbodavidson
Copy link

:lgtm:

Copy link

@turbodavidson turbodavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @prateekshadas)

@prateekshadas prateekshadas merged commit 2ee1721 into caffeine Mar 11, 2021
@prateekshadas prateekshadas deleted the COBS-167 branch March 11, 2021 18:54
prateekshadas added a commit that referenced this pull request Jan 18, 2022
* COBS-167 error message "System under too much load. Broadcast quality may be degraded" occurs when user start streaming in COBS
* Clang format update
prateekshadas added a commit that referenced this pull request Jan 26, 2022
* COBS-167 error message "System under too much load. Broadcast quality may be degraded" occurs when user start streaming in COBS
* Clang format update
prateekshadas added a commit that referenced this pull request Jan 27, 2022
* COBS-167 error message "System under too much load. Broadcast quality may be degraded" occurs when user start streaming in COBS
* Clang format update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants