Skip to content

COBS-66 Caffeine dock is unlisted when opening COBS with a saved account #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prateekshadas merged 1 commit into from
Jul 30, 2020
Merged

COBS-66 Caffeine dock is unlisted when opening COBS with a saved account #86

prateekshadas merged 1 commit into from
Jul 30, 2020

Conversation

@prateekshadas
Copy link

@prateekshadas prateekshadas commented Jul 29, 2020 •
edited
Loading

  • Mac CI builds were taking a long time so fixed that
    To verify if this fixes the problem :
    There are multiple UI States to save the changes in Settings (when connecting/disconnecting Caffeine account ) and should follow following which changing Settings:

    1. Ok button - Should work same as Apply and should save the changes
    2. Cancel Button- Discard the changes
    3. Apply - Apply the changes
    4. Close the Settings Dialog Window with ❌ - Should open up the Message Box Dialog which prompts the user to save the unsaved changes
      • Yes -> save the changes ,
      • No - Discard changes and
      • Cancel - closes the Messages Box dialog.

This change is Reviewable

turbodavidson
turbodavidson approved these changes Jul 30, 2020
View reviewed changes
Copy link

@turbodavidson turbodavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xaymar
Xaymar approved these changes Jul 30, 2020
View reviewed changes
Copy link

@Xaymar Xaymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prateekshadas prateekshadas merged commit 73ec688 into caffeine Jul 30, 2020
@prateekshadas prateekshadas deleted the COBS_66 branch July 31, 2020 00:06
prateekshadas added a commit that referenced this pull request Dec 3, 2020
@prateekshadas
COBS-66 Caffeine dock is unlisted when opening COBS with a saved (#86)
dcc558d
prateekshadas added a commit that referenced this pull request Dec 3, 2020
@prateekshadas
COBS-66 Caffeine dock is unlisted when opening COBS with a saved (#86)
9acd40c
prateekshadas added a commit that referenced this pull request Mar 2, 2021
@prateekshadas
COBS-66 Caffeine dock is unlisted when opening COBS with a saved (#86)
2419913
prateekshadas added a commit that referenced this pull request Mar 2, 2021
@prateekshadas
COBS-66 Caffeine dock is unlisted when opening COBS with a saved (#86)
68af246
prateekshadas added a commit that referenced this pull request Mar 2, 2021
@prateekshadas
COBS-66 Caffeine dock is unlisted when opening COBS with a saved (#86)
540b289
prateekshadas added a commit that referenced this pull request Jan 18, 2022
@prateekshadas
COBS-66 Caffeine dock is unlisted when opening COBS with a saved (#86)
018eef5
prateekshadas added a commit that referenced this pull request Jan 26, 2022
@prateekshadas
COBS-66 Caffeine dock is unlisted when opening COBS with a saved (#86)
b8bc31e
prateekshadas added a commit that referenced this pull request Jan 27, 2022
@prateekshadas
COBS-66 Caffeine dock is unlisted when opening COBS with a saved (#86)
478aed5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Xaymar Xaymar Xaymar approved these changes

@turbodavidson turbodavidson turbodavidson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prateekshadas @Xaymar @turbodavidson