Skip to content

Update Cake.MinVer.yml - #1285

Closed
cake-contrib-bot wants to merge 1 commit into
cake-build:masterfrom
cake-contrib-bot:update_Cake.MinVer.yml_2020_12_01_21_30_04
Closed

Update Cake.MinVer.yml#1285
cake-contrib-bot wants to merge 1 commit into
cake-build:masterfrom
cake-contrib-bot:update_Cake.MinVer.yml_2020_12_01_21_30_04

Conversation

@cake-contrib-bot

Copy link
Copy Markdown
Contributor

This pull request was created by a tool: Cake.AddinDiscoverer version 3.56.0

Resolves #1284

@pascalberger pascalberger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an interesting case: Cake.MinVer 1.0.0-rc0001 references Cake 1.0.0-rc0001.

I see two issues here:

  1. Addin discoverer ignores the pre-release part for TargetCakeVersion
  2. Addin discoverer uses latest pre-release. This is different to which version of the addin we're using on the website (latest stable version, except if there is no stable version yet).

Both versions will lead to invalid results on the website. From a website point of view 0.33.0 would be the expected result. And if an addin a pre-release version of Cake references we would expect the full version (1.0.0-rc0001).

@Jericho Is it possible to adopt addin discoverer to handle these two points?

@Jericho

Jericho commented Dec 1, 2020

Copy link
Copy Markdown
Contributor

It never occurred to me to consider versions with a postfix. The culprit, in AddinDisco source code, is this particular line:

yamlContent.AppendUnixLine($"TargetCakeVersion: {addin.AnalysisResult.GetTargetedCakeVersion().ToString(3)}");

Notice .ToString(3). It will output the version like "x.y.z" and ignore everything else. Give me a few minutes to fix.

@Jericho

Jericho commented Dec 2, 2020

Copy link
Copy Markdown
Contributor

Closing this PR and related issue so that AddinDisco can update the YAML content again and we can verify that the problem with Cake version is resolved.

@Jericho Jericho closed this Dec 2, 2020
@augustoproiete
augustoproiete deleted the update_Cake.MinVer.yml_2020_12_01_21_30_04 branch February 13, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Cake.MinVer.yml

3 participants