Skip to content

loginUrl is expected to be string not array#179

Merged
markstory merged 1 commit into
cakephp:masterfrom
rochamarcelo:patch-1
Feb 7, 2018
Merged

loginUrl is expected to be string not array#179
markstory merged 1 commit into
cakephp:masterfrom
rochamarcelo:patch-1

Conversation

@rochamarcelo

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io

codecov-io commented Feb 6, 2018

Copy link
Copy Markdown

Codecov Report

Merging #179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #179   +/-   ##
=========================================
  Coverage     97.89%   97.89%           
  Complexity      321      321           
=========================================
  Files            33       33           
  Lines           856      856           
=========================================
  Hits            838      838           
  Misses           18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be890a...c692845. Read the comment docs.

@dereuromark dereuromark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should default to array IMO though.

@rochamarcelo

Copy link
Copy Markdown
Contributor Author

Array did not worked for me.

@dereuromark

Copy link
Copy Markdown
Member

Yeah maybe we should set a better default for CakePHP default usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants