Deprecate returning values from event listeners.#18196
Merged
Merged
Conversation
ADmad
force-pushed
the
task/5.2-event-listener-return-value
branch
from
February 20, 2025 05:17
6cb9cc9 to
5889222
Compare
This allows callback methods to have a consistent return type `void`.
ADmad
force-pushed
the
task/5.2-event-listener-return-value
branch
from
February 20, 2025 05:24
5889222 to
3bfec23
Compare
othercorey
approved these changes
Feb 20, 2025
Member
markstory
reviewed
Feb 21, 2025
markstory
left a comment
markstory
left a comment
Member
There was a problem hiding this comment.
I think this makes sense. It removes a redundant way to return values from events and abort them. Does the docstring for setResult() need to change to reflect that it now stops events?
Member
Author
It stops the propagation only if the result is |
ADmad
added a commit
to cakephp/docs
that referenced
this pull request
Feb 22, 2025
LordSimal
pushed a commit
to cakephp/docs
that referenced
this pull request
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows callback methods to have a consistent return type
void.