-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add reference to Oven #4762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference to Oven #4762
Conversation
en/installation.rst
Outdated
| Installation using Oven | ||
| -------------------------------------------------- | ||
|
|
||
| The another quick way to install CakePHP is `Oven <https://github.com/CakeDC/oven>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Another quick" or "The other quick".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
en/installation.rst
Outdated
| -------------------------------------------------- | ||
|
|
||
| The another quick way to install CakePHP is `Oven <https://github.com/CakeDC/oven>`_. | ||
| It is a simple PHP script which installs the CakePHP application skeleton, checks the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't the system requirements checked first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the order.
en/installation.rst
Outdated
| * Upload the oven.php to your server directory. | ||
| * Execute the oven.php via your browser and click on the big oven icon. | ||
|
|
||
| Your CakePHP application is ready to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"After the installation completes, your ..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
en/installation.rst
Outdated
|
|
||
| .. note:: | ||
|
|
||
| IMPORTANT: This is not a deployment script, it's aimed to help developers installing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"script. it is aimed"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was copied from https://github.com/cakedc/oven :)
Anyways, I have updated it.
|
@ravage84 Could you please review the updates? |
ravage84
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone else shall merge. 👍 Thanks!
|
Thanks 👍 |
en/installation.rst
Outdated
| installs the CakePHP application skeleton and sets the development environment up. | ||
|
|
||
| * Upload the oven.php to your server directory. | ||
| * Execute the oven.php via your browser and click on the big oven icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Navigate to
/path/to/oven.phpvia browser ...
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use the same steps as https://github.com/CakeDC/oven/blob/master/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why duplicating if we can Link to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about something like this -
- Navigate to
/path/to/oven.phpvia your browser e.g.http://localhost/cake/oven.phpand click on the big oven icon.
or just
- Navigate to
/path/to/oven.phpvia your browser and click on the big oven icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean we already linked to it, I dont see the need to replicate the README instructions here.
We can omit this part, and start again with "After the installation completes".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree 👍
Fixes #4687