Skip to content

Conversation

@sdevore
Copy link
Contributor

@sdevore sdevore commented Jun 8, 2017

change to use getError, getErrors, setError, setErrors

change to use getError, getErrors, setError, setErrors
@markstory markstory added this to the 3.x milestone Jun 8, 2017
it easier to test code that works with error messages::

$user->setError('password',['Password is required']);
$user->setErrors(['pasword'=>['Password is required'],'username'=>['Username is required']]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks overindented.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it does not respect the coding style : there should be spaces before and after the arrows => and after the comma.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can fix for coding style problems if you would like

@markstory markstory merged commit 5fd99ac into cakephp:3.0 Jun 9, 2017
okinaka added a commit to okinaka/docs that referenced this pull request Jun 21, 2017
@okinaka okinaka mentioned this pull request Jun 21, 2017
okinaka added a commit to okinaka/docs that referenced this pull request Jun 23, 2017
okinaka added a commit to okinaka/docs that referenced this pull request Jun 23, 2017
HavokInspiration added a commit that referenced this pull request Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants