Skip to content

Remove cakephp/cakephp from require. Add orm and cache #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lorenzo merged 1 commit into from
Mar 21, 2017
Merged

Remove cakephp/cakephp from require. Add orm and cache #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@
"require": {
"php": ">=5.5.9",
"robmorgan/phinx": "0.6.6",
"cakephp/cakephp": "~3.2"
"cakephp/orm": "~3.2",
"cakephp/cache": "~3.2"
},
"require-dev": {
"phpunit/phpunit": "~4.1",
"cakephp/cakephp": "~3.2",
Copy link
Copy Markdown
Member

@dereuromark dereuromark Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does mixing the splits and core actually work? Is it necessary then?

Copy link
Copy Markdown
Contributor Author

@harikt harikt Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dereuromark probably I didn't understand what you mean. Can you tell me what split are you telling and what is necessary ?

Copy link
Copy Markdown
Contributor Author

@harikt harikt Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been re-reading your comment and guess what you mean is do we really need cakephp/cakephp itself in require-dev.

If so yes, we need for the test make use of the cakephp tests .

Regarding your comment :

Does mixing the splits and core actually work?

Yes, this is working for there is replace https://github.com/cakephp/cakephp/blob/83a94c084012eac0145b48c95a386f3417139167/composer.json#L61-L75 .

The only requirement for people to use migration is orm and cache. ie it.

"cakephp/bake": "@stable"
},
"autoload": {
Expand Down