Next major - Remove non-builtin commands #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the commands that wrap the phinx commands. This has resulted in more code being removed as well. I also uncovered a bug in `BaseSeed` where it would fail to invoke seeds that were in a non-default `source`.
markstory
force-pushed
the
remove-phinx-commands
branch
from
7aa3abc to
6bb7d97
Compare
Member
Author
|
With 4.7.0 released, there may still be a need for additional features to be added to migrations while the breaking changes are being completed. I decided to add a |
I'm trying to keep the diff small but stan builds are finding all the runtime links to deleted code.
dereuromark
changed the title
markstory
modified the milestones:
4.x (CakePHP 5),
2.x (CakePHP 3),
5.x (CakePHP 5.x, builtin-backend)
LordSimal
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first of several changes to make the builtin backend the only implementation. There are a few more changes that need to be made to finish the removal of phinx, and likely a few more bugs to be uncovered.