Refactor to fully remove phinx dependency. #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fully removes the phinx dependency from the CakePHP migrations plugin, completing the refactoring effort to eliminate external dependencies. The primary goal is to replace all phinx-related classes and imports with the new migrations-specific alternatives, ensuring a clean separation from the legacy phinx library.
- Replaced all
AbstractMigrationandAbstractSeedreferences withBaseMigrationandBaseSeed - Updated imports from
Phinx\*namespaces toMigrations\*namespaces - Updated documentation URLs from phinx to migrations documentation
Reviewed Changes
Copilot reviewed 161 out of 161 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test migration files | Updated base class imports and extends statements throughout test fixtures |
| test seed files | Replaced AbstractSeed with BaseSeed imports and inheritance |
| template files | Updated Twig templates to use new base classes and documentation URLs |
| test case files | Removed phinx-related imports and updated type annotations |
| src/ files | Removed deprecated phinx compatibility shims and unused classes |
markstory
reviewed
Aug 4, 2025
Comment on lines
+28
to
+29
| "symfony/config": "^6.0 || ^7.0", | ||
| "symfony/console": "^6.0 || ^7.0" |
Member
There was a problem hiding this comment.
We should be able to remove these dependencies as well when some more code is removed.
Member
Author
|
Feel free to finish up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #875
@markstory
I went ahead and gave you a helping hand on this one, fully removing the dependency.
I dont think there are too many steps left now
I also